: Photoshop script to select specific colors Please note that I'm a complete beginner and this is my first coding question ever. If this is more appropriate on another site, tell me. I want

@Yeniel278

This is more of a long commentary than an answer. I am not sure selecting color range is the best way to replace color but yes you could do this.


Number of lines dont make more efficient code! One line of code can well be less efficient than a 100. Besides theres code below code so its not like your scripting language is pedal to the metal. Also the scripting API is inherently inefficient if you care for speed then its time to start wirting c++ and use photoshop plugin API.

However, i will take it you mean more practical. Yes we can define some functions to make it easier to read and use, call and slightly more condense. Although making it more practical will increase the length slightly, but this is not meaningfull for you. So let us refactor the code:
#target photoshop

selectColorRange(
RGBc(0.0, 255.0, 0.0),
RGBc(0.0, 255.0, 0.0)
);


/******* Support functions *******/

function cTID(s) { return app.charIDToTypeID(s); }
function sTID(s) { return app.stringIDToTypeID(s); }

function RGBc(r, g, b) {
var color = new ActionDescriptor();
color.putDouble( cTID("Rd "), r);
color.putDouble( cTID("Grn "), g);
color.putDouble( cTID("Bl "), b);
return color
}

function selectColorRange(color1, color2){
var desc = new ActionDescriptor();
desc.putInteger(cTID("Fzns"), 0 );
desc.putObject( cTID("Mnm "), cTID("RGBC"), color1 );
desc.putObject( cTID("Mxm "), cTID("RGBC"), color2 );
executeAction( cTID("ClrR"), desc, DialogModes.NO );
}


So now from your point of view the code is only selectColorRange. Obviously, if you only ever intend to select only one color then you could change selectColorRange to only take one input.

Also even if adobe had this as a javascipt function or object then your code wouldnt be more then 3 lines shorter most likely. Since objects need to be populated anyway.
Well this is pretty easy, you can find many implementations of this by googling. So lot us define a function to do this:

function hexC(hex) {
// stackoverflow.com/questions/5623838/rgb-to-hex-and-hex-to-rgb hex = hex.substring(1,7)
bigint = parseInt(hex, 16);
var color = new ActionDescriptor()
color.putDouble(cTID("Rd "), (bigint >> 16) & 255);
color.putDouble(cTID("Grn "), (bigint >> 8) & 255);
color.putDouble(cTID("Bl "), bigint & 255);
return color
}


So you would call hexC like this,

colorReplace(
hexC("#00ff00"),
hexC("#00ff00")
);


instead of RGBc.


Ok, so now we have all pieces in your code in place. If you have many colors then just call a for loop.

Vote Up Vote Down